aaron.ballman added a comment. Thanks for merging, I think this seems reasonable but is missing some test coverage still.
================ Comment at: clang/lib/Parse/ParseDecl.cpp:4656-4657 !getLangOpts().ObjC) { - ProhibitAttributes(attrs); + ProhibitCXX11Attributes(attrs, diag::err_attributes_not_allowed, + /*DiagnoseEmptyAttrs=*/true); if (BaseType.isUsable()) ---------------- Test coverage for this change? ================ Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1936 if (TUK != Sema::TUK_Declaration && TUK != Sema::TUK_Definition) - ProhibitAttributes(attrs); + ProhibitCXX11Attributes(attrs, diag::err_attributes_not_allowed, + /* DiagnoseEmptyAttrs=*/true); ---------------- Test coverage for this change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits