[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM with a minor improvement for attribute ordering.



================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:732-733
+    // Parse (optional) attributes.
     MaybeParseGNUAttributes(Attrs);
+    MaybeParseCXX11Attributes(Attrs);
+    DiagnoseCXX11AttributeExtension(Attrs);
----------------
You should replace these two lines with a call to: 
`MaybeParseAttributes(PAKM_GNU | PAKM_CXX11, Attrs);` so that order of GNU vs 
CXX syntax doesn't matter (they can be interleaved).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91630/new/

https://reviews.llvm.org/D91630

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits