Author: Aaron Puchert Date: 2021-03-27T23:08:43+01:00 New Revision: c61ae6e6d597984e6ff7d012dce4dfd59c05d792
URL: https://github.com/llvm/llvm-project/commit/c61ae6e6d597984e6ff7d012dce4dfd59c05d792 DIFF: https://github.com/llvm/llvm-project/commit/c61ae6e6d597984e6ff7d012dce4dfd59c05d792.diff LOG: Deduplicate branches and adjust comment [NFC] Currently we want to allow calling non-const methods even when only a shared lock is held, because -Wthread-safety-reference is already quite sensitive and not all code is const-correct. Even if it is, this might require users to add std::as_const around the implicit object argument. See D52395 for a discussion. Fixes PR46963. Added: Modified: clang/lib/Analysis/ThreadSafety.cpp Removed: ################################################################################ diff --git a/clang/lib/Analysis/ThreadSafety.cpp b/clang/lib/Analysis/ThreadSafety.cpp index 21583e92c72d..84e0e91f597f 100644 --- a/clang/lib/Analysis/ThreadSafety.cpp +++ b/clang/lib/Analysis/ThreadSafety.cpp @@ -2051,15 +2051,11 @@ void BuildLockset::VisitCallExpr(const CallExpr *Exp) { if (ME && MD) { if (ME->isArrow()) { - if (MD->isConst()) - checkPtAccess(CE->getImplicitObjectArgument(), AK_Read); - else // FIXME -- should be AK_Written - checkPtAccess(CE->getImplicitObjectArgument(), AK_Read); + // Should perhaps be AK_Written if !MD->isConst(). + checkPtAccess(CE->getImplicitObjectArgument(), AK_Read); } else { - if (MD->isConst()) - checkAccess(CE->getImplicitObjectArgument(), AK_Read); - else // FIXME -- should be AK_Written - checkAccess(CE->getImplicitObjectArgument(), AK_Read); + // Should perhaps be AK_Written if !MD->isConst(). + checkAccess(CE->getImplicitObjectArgument(), AK_Read); } } _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
