bader added a comment. > Yesterday, we chatted offline and agreed that the main issue is missing > documentation for Clang extensions being added for SYCL. To address this > issue we are adding SYCL architecture design document, which we are going to > update along with adding new features.
I'd like to provide a bit more detailed summary. I think meeting was very useful with the following basic outcome: - Need to add references to SYCL spec where applicable - Need to update documentation where references are not enough, in particular: - C++ address space attributes used to implement SYCL address space behavior defined by the specification - main issue is missing documentation for Clang extensions being added for SYCL. - @Anastasia needs some time to read all references/docs provided, some of them has been sent during the meeting Do you agree on the list above or I missed anything? This is what has been done already after the meeting based on the comments made: - I've uploaded SYCL architecture design document with address space section (https://reviews.llvm.org/D99190) and added references to the specification sections describing address spaces. - I checked commits with SYCL functionality and we documented all extensions. In particular `sycl_kernel` attribute mentioned above is documented here - https://clang.llvm.org/docs/AttributeReference.html#sycl-kernel. I believe that currently this PR is in much better shape than it was and I think I addressed all critical missing items that have been mentioned. Can you please review and let me know if anything missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
