steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.
I don't know. I think it's already way better than it was.
I think we can reiterate this later.
I want to get the `llvm_unreachable("Unknown SVal kind")` statements back.
Besides those, I have no objections to this patch.
It preserves the old semantics, so it should be safe to land.
What do you think @NoQ?
================
Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:564-565
}
-
- llvm_unreachable("Unknown SVal kind");
}
----------------
You probably don't want to remove this. The same applies to similar ones.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96090/new/
https://reviews.llvm.org/D96090
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
