MaskRay added a comment. In D97993#2644664 <https://reviews.llvm.org/D97993#2644664>, @thakis wrote:
> Also broke something in chromium: > https://bugs.chromium.org/p/chromium/issues/detail?id=1191244 (since fixed by > switching something from `-B` to `--gcc-toolchain`. This only landed 4 days > ago and already broke a lot of things (see above) -- chances are it's going > to break many more things once it makes it into a release. Is this really > worth the churn? The benefits seem fairly small from what I understand. @thakis The benefit is large. With the previous behavior, the selected toolchain could be overridden by the system /usr and --gcc-toolchain or --sysroot could be accidentally overridden by -B. aeubanks has fixed it via https://chromium-review.googlesource.com/c/chromium/src/+/2781154 That's great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/ https://reviews.llvm.org/D97993 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
