djtodoro added inline comments.
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645
- if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() &&
+ if (Opts.hasReducedDebugInfo() &&
llvm::is_contained(DebugEntryValueArchs, T.getArch()))
----------------
I am a bit confused now :)
Is `flang` using this clang's library?
I think we should be careful here, since I am not sure C/C++ -O0 code has any
benefits of using this, but the DWARF size might be increased insanely.
================
Comment at: llvm/test/DebugInfo/X86/callsitepar-fastisel.ll:12
+;; This test checks if DW_TAG_GNU_call_site_parameter is generated for option
-O0
+;RUN: clang -cc1 -triple x86_64-unknown-linux-gnu -emit-obj -main-file-name
%s -debug-info-kind=limited -dwarf-version=4 -debugger-tuning=gdb -O0 -x ir %s
-o - | llvm-dwarfdump - | FileCheck %s --check-prefix=CLANG
----------------
I don't think this should be tested this way. We should be testing `Driver`
itself.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99238/new/
https://reviews.llvm.org/D99238
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
