alok added inline comments.

================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645
 
-  if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() &&
       llvm::is_contained(DebugEntryValueArchs, T.getArch()))
----------------
djtodoro wrote:
> I think this should be a different patch.
> 
> Are you saying this is useful for some -O0 cases? Can you please provide a 
> test case? Is this related to Fortran only?
Sure. I shall move this in separate patch.

Yes this is useful in -O0 case. the testcase is added with the current patch as 
"callsitepar-fastisel.ll". Though the IR is generated from fortran program 
(mentioned in test case). But I think it is not specific to fortran. Since even 
with -O0 many optimizations work, it is very much possible that parameter gets 
optimized out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99160/new/

https://reviews.llvm.org/D99160

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to