dblaikie added a comment.

In D97411#2642194 <https://reviews.llvm.org/D97411#2642194>, @akhuang wrote:

>> Hmm - is that type used in a way that invokes Undefined Behavior? Or is this 
>> a gap/bug in the ctor homing? I thought there was already a special case for 
>> constexpr ctors that opted them out of ctor homing.
>
> Right, I think the constexpr is only used in >c++17 for some reason, so 
> doesn't apply here. I looked around a bit but still not sure how/where 
> `allocator`s are constructed.

Fair enough - guess that's a discussion to have on a separate thread/when we 
talk about adding the attribute to libc++/or when bugfixing the ctor homing, if 
it turns out/looks like a gap in ctor homing to address there. (happy to 
discuss it whenever - email/chat/etc)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97411/new/

https://reviews.llvm.org/D97411

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to