sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/ConfigFragment.h:244 + struct CompletionBlock { + /// Whether code completion should include results from scopes that are not + /// visible. ---------------- Maybe s/results/suggestions/, emphasizing that these are going to be guesses? Consider also "The required scope prefix will be inserted." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98037/new/ https://reviews.llvm.org/D98037 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits