kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12 +if (ENABLE_GRPC_REFLECTION) + set(REFLECTION_LIBRARY grpc++_reflection) ---------------- can we move this piece into FindGRPC.cmake instead? ================ Comment at: llvm/cmake/modules/FindGRPC.cmake:21 # the conventional system-installed names. - set_target_properties(protobuf::libprotobuf PROPERTIES IMPORTED_GLOBAL TRUE) - add_library(protobuf ALIAS protobuf::libprotobuf) ---------------- nit: is this change needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
