beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land.
So... this patch is fine. (marked as approved). That said, we should really be working to remove the `LLVM_BUILD_EXTERNAL_COMPILER_RT` option entirely in favor of just using `LLVM_ENABLE_RUNTIMES=compiler-rt`. That build process does support invoking the sub-project build on build invocation to make sure builds get re-run, and it supports better understanding of the dependencies between runtimes. Have you considered using that instead of `LLVM_BUILD_EXTERNAL_COMPILER_RT`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98291/new/ https://reviews.llvm.org/D98291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
