jansvoboda11 added a comment.

In D97743#2614480 <https://reviews.llvm.org/D97743#2614480>, @MaskRay wrote:

> In D97743#2613629 <https://reviews.llvm.org/D97743#2613629>, @jansvoboda11 
> wrote:
>
>> Could the logic be implemented in the driver?
>>
>> LGTM regardless.
>
> No. `Res` is a `clang::CompilerInvocation` object. `CompilerInvocation` is 
> not in the driver... `-D` `-U` and `__CET__` are implemented in this file, 
> too.

Right. I meant if it would be possible to move the logic to the driver and pass 
`-D__GCC_HAVE_DWARF2_CFI_ASM=1` explicitly from the driver to `-cc1`, keeping 
`CompilerInvocation` as simple as possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97743/new/

https://reviews.llvm.org/D97743

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to