kbobyrev added inline comments.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:17453
+    }
+    return T.isPODType(Sema.getASTContext());
+  }();
----------------
sammccall wrote:
> POD is rarely precisely the right concept (and deprecated for that reason).
> Is isTriviallyCopyableType() just as good here?
Also, maybe `if (T->isTriviallyCopyableType(Sema.getASTContext())) return 
true;` at the top and just `return false;` here? This saves us the necessity to 
iterate through the ctors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96975/new/

https://reviews.llvm.org/D96975

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to