krasimir added a comment.

In D97688#2610657 <https://reviews.llvm.org/D97688#2610657>, @sammccall wrote:

>> Also fixes a bug where the canonical delimiter was not applied for raw 
>> strings with empty delimiters detected via well-known enclosing functions 
>> that expect a text proto.
>
> Are you sure this was a bug rather than intended behavior? Seems... not 
> unreasonable.
>
> CanonicalDelemiter seems very rarely used so far though, so should be safe.

Good point! I agree that is a reasonable behavior as well, so it's not a bug 
but a change of behavior. Agree that this should be safe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97688/new/

https://reviews.llvm.org/D97688

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to