hokein added a comment. The code looks good, but I don't have a very strong opinion of making the resource-dir as a config option. Do we have a motivation (e.g. user request?) now?
================ Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:381 } // namespace clang - ---------------- looks like removing the eof is an accident change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97935/new/ https://reviews.llvm.org/D97935 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
