nickdesaulniers added inline comments.
================ Comment at: clang/docs/ClangCommandLineReference.rst:23 -Add <dir> to search path for binaries and object files used implicitly +Search $prefix/$triple-$file and $prefix$file for executables, libraries, includes and data files used by the compiler. If $prefix is a directory, the directory is used to search for GCC installation on targets which commonly use GCC. The directory usually contains 'include' and 'lib'. If $prefix is not a directory, the GCC installation detection is skipped but $prefix can still be used to find executables, typically for -nostdinc -nostdlib compiles ---------------- MaskRay wrote: > nickdesaulniers wrote: > > I like how `--gcc-toolchain` references `-B`; can `-B` also reference > > `--gcc-toolchain`? That way developers also understand their options when > > looking at either? Or should we move `--gcc-toolchain` to be closer to > > `-B`, since they're slightly similar? > `clang-tblgen -I ../llvm/include -I include/clang/Driver -gen-opt-docs > include/clang/Driver/ClangOptionDocs.td` sorts the options alphabetically so > it is not easy to move them together... Ok. Can we still refer to `--gcc-toolchain` from here? ================ Comment at: clang/docs/ClangCommandLineReference.rst:259 -Use the gcc toolchain at the given directory +Search for GCC installation in the specified directory, similar to -B<dir>.The directory usually contains 'lib' and 'include'.If specified, sysroot is not skipped for GCC detection ---------------- nickdesaulniers wrote: > Add whitespace after periods. Looks like there's another instance of this comment on this line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https://reviews.llvm.org/D97902 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
