kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:784
Server->workspaceSymbols(
- Params.query, Opts.CodeComplete.Limit,
+ Params.query, Params.limit.getValueOr(Opts.CodeComplete.Limit),
[Reply = std::move(Reply),
----------------
should we check for non-negativity in here as well ? (or maybe just change
deserialization logic to set it to none for negative ones and store a size_t
instead)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97801/new/
https://reviews.llvm.org/D97801
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
