Author: Nathan James Date: 2021-03-03T02:53:10Z New Revision: 335375ef2c66408da751223d13758d14da248cd3
URL: https://github.com/llvm/llvm-project/commit/335375ef2c66408da751223d13758d14da248cd3 DIFF: https://github.com/llvm/llvm-project/commit/335375ef2c66408da751223d13758d14da248cd3.diff LOG: [clang][NFC] pack StaticDiagInfoRec Exchanging types, reordering fields and borrowing a bit from OptionGroupIndex shrinks this from 12 bytes to 8. This knocks ~20k from the binary size. Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D97553 Added: Modified: clang/lib/Basic/DiagnosticIDs.cpp Removed: ################################################################################ diff --git a/clang/lib/Basic/DiagnosticIDs.cpp b/clang/lib/Basic/DiagnosticIDs.cpp index 06a8e2ed5ebd..c333076d2efc 100644 --- a/clang/lib/Basic/DiagnosticIDs.cpp +++ b/clang/lib/Basic/DiagnosticIDs.cpp @@ -109,15 +109,15 @@ enum { struct StaticDiagInfoRec { uint16_t DiagID; - unsigned DefaultSeverity : 3; - unsigned Class : 3; - unsigned SFINAE : 2; - unsigned WarnNoWerror : 1; - unsigned WarnShowInSystemHeader : 1; - unsigned Deferrable : 1; - unsigned Category : 6; + uint8_t DefaultSeverity : 3; + uint8_t Class : 3; + uint8_t SFINAE : 2; + uint8_t Category : 6; + uint8_t WarnNoWerror : 1; + uint8_t WarnShowInSystemHeader : 1; - uint16_t OptionGroupIndex; + uint16_t OptionGroupIndex : 15; + uint16_t Deferrable : 1; uint16_t DescriptionLen; @@ -168,20 +168,20 @@ VALIDATE_DIAG_SIZE(REFACTORING) #undef STRINGIFY_NAME const StaticDiagInfoRec StaticDiagInfo[] = { +// clang-format off #define DIAG(ENUM, CLASS, DEFAULT_SEVERITY, DESC, GROUP, SFINAE, NOWERROR, \ - SHOWINSYSHEADER, DEFERRABLE, CATEGORY) \ + SHOWINSYSHEADER, DEFERRABLE, CATEGORY) \ { \ diag::ENUM, \ DEFAULT_SEVERITY, \ CLASS, \ DiagnosticIDs::SFINAE, \ + CATEGORY, \ NOWERROR, \ SHOWINSYSHEADER, \ - DEFERRABLE, \ - CATEGORY, \ GROUP, \ + DEFERRABLE, \ STR_SIZE(DESC, uint16_t)}, -// clang-format off #include "clang/Basic/DiagnosticCommonKinds.inc" #include "clang/Basic/DiagnosticDriverKinds.inc" #include "clang/Basic/DiagnosticFrontendKinds.inc" @@ -194,7 +194,7 @@ const StaticDiagInfoRec StaticDiagInfo[] = { #include "clang/Basic/DiagnosticSemaKinds.inc" #include "clang/Basic/DiagnosticAnalysisKinds.inc" #include "clang/Basic/DiagnosticRefactoringKinds.inc" - // clang-format on +// clang-format on #undef DIAG }; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
