aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a small change to the diagnostic (routine -> a function, and adding single quotes around the syntax element in the diagnostic). ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:297-298 +def err_anyx86_interrupt_regsave : Error< + "interrupt service routine may only call routine" + " with attribute no_caller_saved_registers">; def warn_arm_interrupt_calling_convention : Warning< ---------------- New suggested diagnostic wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97764/new/ https://reviews.llvm.org/D97764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
