aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a nit with the diagnostic wording. ================ Comment at: clang-tools-extra/clang-tidy/misc/UniqueptrResetReleaseCheck.cpp:115 + auto D = diag(ResetMember->getExprLoc(), + "prefer 'unique_ptr<>' assignment over release and reset"); + if (ResetMember->isArrow()) ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97632/new/ https://reviews.llvm.org/D97632 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
