erichkeane added inline comments.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946
+ FunctionEmissionStatus FES = getEmissionStatus(FD);
+ switch (FES) {
+ case FunctionEmissionStatus::Emitted:
----------------
pmrao wrote:
> erichkeane wrote:
> > pmrao wrote:
> > > erichkeane wrote:
> > > > Tabs here instead of spaces.
> > > >
> > > > I think this is the right fix for SYCL, but @bader should double-check
> > > > that he's ok with this or OMP.
> > > > Tabs here instead of spaces.
> > >
> > > Are you suggesting that I change the spaces to tabs instead?
> > The reverse. Change the tabs you have at the beginning of the line to
> > spaces. I believe that is what the double-arrow character in Phab
> > represents (a tab).
> Oh! I misunderstood then. I thought phab was indicating that there are no
> changes in the line, except new indentation.
>
> I didn't use tabs in my source file. I don't see it in the character set.
> Perhaps something introduced it during the upload. I will check.
Oh, it looks like you're right, that must be a new feature of Phab that looks
shockingly like an old one :) I don't see tabs in the downloaded diff file, so
consider that comment 'done'.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97573/new/
https://reviews.llvm.org/D97573
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
