rjmccall added a comment.

LGTM other than the TargetInfo thing.



================
Comment at: clang/include/clang/Basic/TargetInfo.h:1424
+           triple.isAArch64();
+  }
+
----------------
As I commented in the other patch, I think this would be cleaner in the long 
term if you just implemented it directly in the various target subclasses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95561/new/

https://reviews.llvm.org/D95561

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to