tskeith added inline comments.
================ Comment at: flang/lib/Frontend/CompilerInvocation.cpp:234 + // -J/module-dir option + auto &moduleDir = res.moduleDir(); auto moduleDirList = ---------------- In my opinion, using mutable references like this make the code hard to understand. Setters on CompilerInvocation would be clearer. ================ Comment at: flang/test/Semantics/mod-file-rewriter.f90:9 +! RUN: %flang-new -fsyntax-only -fdebug-module-writer %p/Inputs/mod-file-unchanged.f90 2>&1 | FileCheck %s --check-prefix CHECK_UNCHANGED +! RUN: %flang-new -fsyntax-only -fdebug-module-writer %p/Inputs/mod-file-changed.f90 2>&1 | FileCheck %s --check-prefix CHECK_CHANGED ---------------- Why do you need to duplicate these lines? Doesn't it work to use `%flang`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
