ASDenysPetrov added a comment. In D95246#2566417 <https://reviews.llvm.org/D95246#2566417>, @abhina.sreeskantharajan wrote:
> I was curious if all of these modified testcases are now failing or only the > three you mentioned. Here is the list of the tests which fail after the patch (I haven't build LLD so don't have tests as well): Clang :: CodeGen/basic-block-sections.c Clang :: CodeGen/ubsan-blacklist-vfs.c Clang :: Frontend/output-paths.c Clang :: Frontend/stats-file.c LLVM :: DebugInfo/symbolize-missing-file.test LLVM :: Object/archive-extract-dir.test LLVM :: Object/directory.ll LLVM :: tools/llvm-ar/error-opening-directory.test LLVM :: tools/llvm-ar/missing-thin-archive-member.test LLVM :: tools/llvm-ar/move.test LLVM :: tools/llvm-ar/print.test LLVM :: tools/llvm-ar/quick-append.test LLVM :: tools/llvm-ar/replace.test LLVM :: tools/llvm-ar/response.test LLVM :: tools/llvm-cxxdump/trivial.test LLVM :: tools/llvm-libtool-darwin/filelist.test LLVM :: tools/llvm-libtool-darwin/invalid-input-output-args.test LLVM :: tools/llvm-lipo/create-arch.test LLVM :: tools/llvm-lipo/replace-invalid-input.test LLVM :: tools/llvm-lto/error.ll LLVM :: tools/llvm-lto2/X86/stats-file-option.ll LLVM :: tools/llvm-mc/basic.test LLVM :: tools/llvm-mca/invalid_input_file_name.test LLVM :: tools/llvm-ml/basic.test LLVM :: tools/llvm-objcopy/COFF/add-section.test LLVM :: tools/llvm-objcopy/ELF/add-section.test LLVM :: tools/llvm-objcopy/ELF/error-format.test LLVM :: tools/llvm-objcopy/MachO/add-section-error.test LLVM :: tools/llvm-objcopy/redefine-symbols.test LLVM :: tools/llvm-objcopy/wasm/dump-section.test LLVM :: tools/llvm-profdata/weight-instr.test LLVM :: tools/llvm-profdata/weight-sample.test LLVM :: tools/llvm-readobj/ELF/thin-archive-paths.test LLVM :: tools/llvm-readobj/basic.test LLVM :: tools/llvm-readobj/thin-archive.test LLVM :: tools/llvm-size/no-input.test LLVM :: tools/llvm-xray/X86/no-such-file.txt LLVM :: tools/obj2yaml/invalid_input_file.test LLVM :: tools/yaml2obj/output-file.yaml > I also don't know how this change can cause a pop-up to occur, is there more > information you can provide? I got this. The popups is not the fault of this patch. They happened earlier. I'll investigate it later. > llvm/test/tools/llvm-elfabi/fail-file-write-windows.test > > I did not modify this but it requires system-windows and has a lower-case > error message. I expect if my change causes failures for you, then this > testcase should also fail. Yes, this fails for me too. Didn't check it earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
