amyk added a comment. In addition to the nit comments, I also have the same question as Stefan for `getFPAs64BitIntHi`/`getFPAs64BitIntLo`.
================ Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8591 + // Only convert if it loses info, since XXSPLTIDP should + // handle the other case + return !ArgAPFloat.isDenormal() && ---------------- nit: end with period. ================ Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:2609 +// To replace constant pool with XXSPLI32DX for scalars. +def : Pat<(f32 nzFPImmAsi64 ---------------- ================ Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:2611 +def : Pat<(f32 nzFPImmAsi64 + : $A), + (COPY_TO_REGCLASS(XXSPLTI32DX(XXSPLTI32DX(IMPLICIT_DEF), 0, ---------------- Have this `: $A` on the line above? Same as the one below. Also a minor nit, but add a space to separate the `(`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95458/new/ https://reviews.llvm.org/D95458 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
