aykevl added a comment. This looks good to me, although I would like someone else to take a look as well. I can confirm that these changes fix an issue on AVR: this patch (together with D86547 <https://reviews.llvm.org/D86547>) make `__floatsisf` correct on AVR while it would previously do something incorrect.
What I am somewhat worried about is that some of these functions (`__floatsisf`, `__floatunsisf`) do not have tests. I think the test for the *vfp variants could be shared between the *vfp and non-*vfp variants. But I think this is best done separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86546/new/ https://reviews.llvm.org/D86546 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
