rprichard added a subscriber: emaste.
rprichard added a comment.

emaste: Just a heads up in case FreeBSD is affected. FWIW, I noticed that 
libgcc_eh.a on FreeBSD 12.1 doesn't hide the `_Unwind_*` or `unw_*` symbols. 
The build system 
<https://github.com/freebsd/freebsd-src/blob/1e811efbc591699b872bea42b9de419c373199df/lib/libgcc_eh/Makefile.inc#L7>
 is defining `VISIBILITY_HIDDEN` but libunwind doesn't respond to that name. 
FreeBSD libgcc_eh.a also defines hidden symbols named `logAPIs`, 
`logUnwinding`, and `logDWARF`. libunwind defines these internal names if 
`NDEBUG` isn't defined. They can break statically-linked programs on FreeBSD 
(e.g. duplicate symbol linker errors).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93003/new/

https://reviews.llvm.org/D93003

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to