dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Sounds good. Out of curiosity, how'd you come across this/do you have any
particular use case that uses DW_AT_external?
================
Comment at: clang/test/CodeGenCXX/debug-info-class.cpp:27-34
+namespace {
struct D {
- D();
- virtual ~D();
+ D() {}
+ virtual ~D() {}
void func() {
}
};
----------------
Might be better to add a separate class to test this case - modifying this
class may reduce coverage of existing features (the vtable homing (well, lack
of homing due to `~D` being virtual and inline) would no longer be tested
here, since the type is internal and that'd override the other logic.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96044/new/
https://reviews.llvm.org/D96044
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
