tra added inline comments.
================
Comment at: clang/lib/AST/ASTContext.cpp:11437-11443
+ return ((!getLangOpts().GPURelocatableDeviceCode &&
+ ((D->hasAttr<CUDADeviceAttr>() &&
+ !D->getAttr<CUDADeviceAttr>()->isImplicit()) ||
+ (D->hasAttr<CUDAConstantAttr>() &&
+ !D->getAttr<CUDAConstantAttr>()->isImplicit()))) ||
D->hasAttr<HIPManagedAttr>()) &&
isa<VarDecl>(D) && cast<VarDecl>(D)->getStorageClass() == SC_Static;
----------------
yaxunl wrote:
> tra wrote:
> > I can't parse it. :-( Perhaps we can split it.
> revised
I still can't read it. way too many nested operands to logical operators...
I was thinking of extracting parts of the equation into early returns or
intermediate variables.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95901/new/
https://reviews.llvm.org/D95901
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
