yaxunl added a comment. In D95915#2539483 <https://reviews.llvm.org/D95915#2539483>, @jdoerfert wrote:
> I don't believe a static variable is a good idea. Also the name is not really > informative. Members in `ToolChain` with a proper names would be nicer (IMHO). > > Tests missing. Also, now you don't warn for different missing runtimes, which > seems odd. +1 I agree with Johannes about static variable usage. We should avoid using static variables since they are not thread safe and become hurdles when we want to parallelize the driver. Is it possible to emit the diag in a lambda and use std::call_once with it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
