sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:322
- Scopes.push_back("");
+ std::set<std::string> Scopes;
+ Scopes.insert("");
----------------
nit: sort+erase-unique is probably cheaper than constructing a set and then
copying it
(probably not a huge deal but we do this for each typo I think)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95942/new/
https://reviews.llvm.org/D95942
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
