Conanap added a comment.

Added a note on one of the functions



================
Comment at: lld/ELF/Driver.cpp:765
+// instructions in stubs.
+static bool getP10StubOpt(opt::InputArgList &args) {
+
----------------
For this function here, I realize we can inline all the ifs into a giant return 
statement - is there any opinions on this? I thought the if statements might 
make this a bit more readable, but if it is preferred that there is only 1 
return statement I can make that change as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94627/new/

https://reviews.llvm.org/D94627

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to