njames93 edited reviewers, added: aaron.ballman, alexfh, njames93; removed:
sammccall, hokein.
njames93 accepted this revision.
njames93 added a comment.
This revision is now accepted and ready to land.
LGTM, Can you fix the formatting as well.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/modernize-loop-convert-multidimensional.cpp:50
+ Vector<Vector<Vector<int>>> Y;
+ for (int J = 0; J < Y[3].size(); ++J) {
+ if (Y[3][J][7])
----------------
Not essential, but how would this handle iterating the lowest dimension.
```lang=c++
for (int J = 0; J < Y[3][4].size(); ++J)
```
Though I may have a feeling the check won't even try to convert that. If so
disregard this comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95771/new/
https://reviews.llvm.org/D95771
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
