hubert.reinterpretcast added inline comments. BRANCHES main
/clang/lib/Driver/ToolChains/Clang.cpp:4672-4678 This seems to be saying that `-maltivec` rather actively implies `-mabi=vec-default` (on AIX) even in cases where `-maltivec` really makes no difference. I suggest just removing this. If kept, this needs more code comments and should be moved below to become a check only in the case where neither `-mabi=vec-extabi` nor `-mabi=vec-default` was present. /clang/lib/Driver/ToolChains/Clang.cpp:4687 This `if` can be replaced with `else`. In this case, although the body of the preceding `if` "exits", I think using `else` is reasonable since the mechanism used is not a standard library function or jump statement. Any qualms about this can also be alleviated by reversing the order of the check. Users: ZarkoCA (Author) https://reviews.llvm.org/rGcaaaebcde462 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
