varungandhi-apple added inline comments.
================ Comment at: clang/lib/AST/MicrosoftMangle.cpp:2688-2689 // ::= S # __attribute__((__swiftcall__)) // Clang-only + // ::= T # __attribute__((__swiftasynccall__)) // + // Clang-only // ::= w # __regcall ---------------- Whitespace needs fixing after comment was broken up by `arc`'s linter. ================ Comment at: llvm/lib/Demangle/MicrosoftDemangleNodes.cpp:114 + case CallingConv::SwiftAsync: + OS << "__attribute__((__swiftasynccall__))"; + break; ---------------- Need to add extra whitespace at end similar to `__swiftcall__`. ================ Comment at: llvm/test/Demangle/ms-mangle.test:345 +?swift_async_func@@YTXXZ +; CHECK: void __attribute__((__swiftasynccall__))swift_async_func(void) + ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://reviews.llvm.org/D95561 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits