jansvoboda11 added inline comments.
================ Comment at: clang/include/clang/Frontend/CompilerInvocation.h:144 + /// Container holding strings allocated during round-trip. + mutable std::forward_list<std::string> AllocatedStrings; + ---------------- dexonsmith wrote: > I suggest using llvm::StringPool instead, which also uniques the strings and > is used elsewhere for this kind of thing. Probably in an Optional to make it > more clear it’s not always used. > > Maybe the name RoundTrippedStrings? From the documentation of `StringPool`, it seems like we would need to store `PooledStringPtr`s in order to keep them alive. How would that work with the `const char *` API we have? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95514/new/ https://reviews.llvm.org/D95514 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
