aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land.
================ Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 + return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && + MandatoryInliningKind::Always == ---------------- mtrofin wrote: > aeubanks wrote: > > I see this check a lot, should this be handled in some common place > > instead? Like `getMandatoryKind()`? > this is the recursion avoidance test. it's separate from mandatory - I > suppose we can factor it upfront. We don't inline self-recursive CallBases right? Seems like we should always get a `Never` in that case. But not super important to factor that out right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94825/new/ https://reviews.llvm.org/D94825 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
