akhuang added a comment. In D94639#2496950 <https://reviews.llvm.org/D94639#2496950>, @dblaikie wrote:
> In D94639#2496923 <https://reviews.llvm.org/D94639#2496923>, @akhuang wrote: > >> In D94639#2496892 <https://reviews.llvm.org/D94639#2496892>, @dblaikie wrote: >> >>> What parts of this are motivated by CodeView requirements (do functions >>> have to have unique names in CV?)? > > Might be worth rephrasing from "emit type information for function scopes" to > "emit parent/context scopes for functions, using declarations for any scopes > that are types". (my own fault, but reading this quickly, I assumed it was > about emitting type information for the parameters (DWARF gmlt drops the > parameters/types)) That sounds good > How does any of this deal with overloading? I guess for either solution > (qualified name or real scopes) you have to include all the parameter type > info too to avoid the functions being treated as identical/duplicate by CV? Yep, this patch doesn't deal with overloading or lambdas. For lambdas I have a separate patch, and for overloading I haven't really thought much about yet. Seems like we'd have to include all the parameter type info somehow (or include all the parameters in the display name). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94639/new/ https://reviews.llvm.org/D94639 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
