jlebar added a comment.

Hi, welcome!  Thank you for the careful and well-motivated first commit.  (I 
also see https://github.com/ccache/ccache/issues/772, hooray for noticing 
that...)

I am also not 100% sure how to write a test, but I think you may be able to 
observe the effect of your driver changes by running `clang -###`.  I'd expect 
you'd then see `-x cuda` in the output?

Same for the `.cuhi` change; I presume that with `-###` you'll be able to see 
that the driver is building a PCH with output name `.cuhi` even if that would 
crash if it actually went through.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94337/new/

https://reviews.llvm.org/D94337

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to