MaskRay added inline comments.

================
Comment at: clang/test/CodeGenCXX/difile_entry.cpp:1
+// RUN: rm -rf %t/test_dir
+// RUN: mkdir -p %t/test_dir
----------------
MaskRay wrote:
> @umesh.kalappa0 Can you clarify how this test demonstrates the behavior 
> difference?
> 
> Reverting the code part does not make the test fail.
Seems that absolute path needs to be used. `../test_dir/difile_entry.cpp` 
cannot demonstrate the difference. I'll improve the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87147/new/

https://reviews.llvm.org/D87147

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to