MyDeveloperDay added subscribers: krasimir, klimek.
MyDeveloperDay added a comment.

@rjelonek  please don't set the editable to "clang" but leave it as all users

F14974099: image.png <https://reviews.llvm.org/F14974099>

otherwise only members of the clang project can actually edit it the review and 
leave comments (this massively cuts down who can review it)

Also not wanting to talk for @rsmith but you need to ensure that you are adding 
people as reviewers who generally look after #clang-format 
<https://reviews.llvm.org/tag/clang-format/> for which I'm always happy to be a 
reviewer, but a quick look at other clang-format commits will give you an idea 
of people  who at least I normally include (but not limited to)  @curdeius , 
@krasimir , @klimek  these people are well versed in how clang-format works. 
Not all may have time to respond.

see https://llvm.org/docs/Phabricator.html#finding-potential-reviewers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94206/new/

https://reviews.llvm.org/D94206

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to