MyDeveloperDay added a comment.

In D94201#2483824 <https://reviews.llvm.org/D94201#2483824>, 
@HazardyKnusperkeks wrote:

> Should the BOM not be ignored in ANY case, not just while sorting includes? 
> And thus a different code should be touched?
>
> How about aligned assignments at the beginning of the line with a BOM, does 
> it count to the type name, or does clang-format handle that correctly right 
> now?

I think its better that issues are kept small and compact and single units of 
work, lets not make more problems for ourselves by making every bug have to fix 
every possible permutation.

I follow the "Beyonce Rule" if aligned assignments are an issue when using BOM 
then the person who added that "should have put a test on it"

But @HazardyKnusperkeks feel free to investigate that if you are interested to 
see if this issue is further reaching, patches are always welcome


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94201/new/

https://reviews.llvm.org/D94201

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to