DavidTruby marked 2 inline comments as done. DavidTruby added inline comments.
================ Comment at: clang/lib/CodeGen/TargetInfo.cpp:5137 + + if (!isHomogeneousAggregateForABI(CXXRD)) + return false; ---------------- rnk wrote: > Apologies for moving the goalposts, but after re-reading the code, I feel > like it would make more sense to make this a CGCXXABI virtual method. This > code then would read: > if (!getCXXABI().isPermittedToBeHomogeneousAggregate(CXXRD)) > return false; > > IMO it also makes sense to move this up before checking bases. I agree this is much cleaner and have made the change based on your suggestion. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92751/new/ https://reviews.llvm.org/D92751 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
