MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:260
+ case llvm::Triple::ppcle:
+ return "elf32lppc";
case llvm::Triple::ppc64:
----------------
This needs a linker test in clang/test/Driver/ppc-features.cpp
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3297
!(TT.getArch() == llvm::Triple::aarch64 ||
- TT.getArch() == llvm::Triple::ppc ||
- TT.getArch() == llvm::Triple::ppc64 ||
- TT.getArch() == llvm::Triple::ppc64le ||
+ TT.isPPC() ||
TT.getArch() == llvm::Triple::nvptx ||
----------------
Please format
================
Comment at: clang/test/Driver/ppc-endian.c:1
-// RUN: %clang -target powerpc64le -### -c %s 2>&1 | FileCheck
-check-prefix=CHECK-LE %s
-// RUN: %clang -target powerpc64le -mlittle-endian -### -c %s 2>&1 | FileCheck
-check-prefix=CHECK-LE %s
-// RUN: %clang -target powerpc64 -mlittle-endian -### -c %s 2>&1 | FileCheck
-check-prefix=CHECK-LE %s
-// CHECK-LE: "-cc1"{{.*}} "-triple" "powerpc64le{{.*}}"
+// RUN: %clang -target powerpc-unknown -### -c %s 2>&1 | FileCheck
-check-prefix=CHECK-BE32 %s
+// RUN: %clang -target powerpc-unknown -mbig-endian -### -c %s 2>&1 |
FileCheck -check-prefix=CHECK-BE32 %s
----------------
"-unknown" is correct, though I usually omit it as it is not useful...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93919/new/
https://reviews.llvm.org/D93919
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
