aqjune marked an inline comment as done. aqjune added inline comments.
================ Comment at: llvm/lib/IR/IRBuilder.cpp:1020 Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC)); - return CreateShuffleVector(V, Undef, Zeros, Name + ".splat"); + return CreateShuffleVector(V, Poison, Zeros, Name + ".splat"); } ---------------- spatel wrote: > I'm still catching up on reviews/mails, so ignore if this was already > discussed: > Can we change this usage of CreateShuffleVector to the unary operand version, > so we're reducing the number of explicit places where we need to specify > poison? Yes, it makes sense. I'll update D93817 to use the unary version as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93793/new/ https://reviews.llvm.org/D93793 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
