hoy added a comment. In D93747#2470387 <https://reviews.llvm.org/D93747#2470387>, @dblaikie wrote:
> Please remove the clang test change - if this is an LLVM change with LLVM > test coverage, that's enough. (we don't generally test every LLVM change from > both LLVM and Clang) Sounds good. > I'd still be curious if you could look around to see whether there are other > cases of function splitting/cloning/etc to see how they deal with updating > the DISubprograms, to see if there's some prior art that should be used here. To the best of my knowledge, existing code does not change the linkage name field of a DISubprogram once created. You can create a new DISubprogram record with any linkage name you want but bear in mind how the debugger will consume the record. Looks like we are the first one to change existing record which will confuse the debugger. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
