aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM!
================ Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:101 - ignoringImpCasts(stringLiteral(hasSize(0))), - ignoringImpCasts(cxxBindTemporaryExpr(has(DefaultConstructor))), - ignoringImplicit(DefaultConstructor), ---------------- steveire wrote: > aaron.ballman wrote: > > We seem to lose this case entirely? > In `IgnoreUnlessSpelledInSource` mode, > `ignoringImpCasts(cxxBindTemporaryExpr(has(DefaultConstructor)))` simplifies > to `cxxConstructExpr(isDefaultConstruction())`, which is there. Ah, exactly right, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91303/new/ https://reviews.llvm.org/D91303 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
