dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:338
+                                    const std::vector<std::string> &Values) {
+  for (const std::string& Value : Values) {
+    denormalizeString(Args, Spelling, SA, OptClass, TableIndex, Value);
----------------
Nit: we usually put the `&` next to the variable name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93631/new/

https://reviews.llvm.org/D93631

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D93631: [c... Jan Svoboda via Phabricator via cfe-commits
    • [PATCH] D9363... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D9363... Jan Svoboda via Phabricator via cfe-commits

Reply via email to