efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land.
LGTM with one minor comment. Do you have commit access? If not, I can merge for you; please specify your preferred git "Author" line. ================ Comment at: clang/test/CodeGenCXX/ppc32-varargs-method.cpp:15 +// CHECK-NEXT: load i8*, i8** %{{[0-9]+}}, align 4 +// CHECK-NEXT: mul i8 %numUsedRegs, 4 +// CHECK-NEXT: getelementptr inbounds i8, i8* %{{[0-9]+}}, i8 %{{[0-9]+}} ---------------- Not sure referring to numUsedRegs like this will work in a non-Asserts build. Please verify. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90329/new/ https://reviews.llvm.org/D90329 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits